github-vet / github-vet/rangeloop-pointer-findings

gardener/gem: pkg/gem/gem.go; 25 LoC

Open
#17,020 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gardener/gem](https://www.github.com/gardener/gem) at [pkg/gem/gem.go](https://github.com/gardener/gem/blob/1d545269245eeb9dceca609e87544cebb7020a20/pkg/gem/gem.go#L240-L264)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/gardener/gem/blob/1d545269245eeb9dceca609e87544cebb7020a20/pkg/gem/gem.go#L240-L264)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for moduleKey, requirement := range requirements.Requirements {
log := withModuleKeyRequirementLogger(g.log, moduleKey, requirement)
log.Info("Fetching")

log.Debug("Retrieving repository")
repositoryInterface, err := g.Repository(moduleKey.Repository)
if err != nil {
return nil, err
}

log.Debug("Checking whether lock for is present")
lock, ok := locks.Locks[moduleKey]
if !ok {
return nil, fmt.Errorf("no lock recorded for %s", moduleKey)
}

log.Debug("Fetching controller installation")
registration, err := repositoryInterface.Fetch(moduleKey.Submodule, requirement, lock)
if err != nil {
return nil, errors.Wrapf(err, "could not fetch registration for %s", &moduleKey)
}

log.Info("Successfully fetched")
registrations = append(registrations, registration)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Wrapf 3} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1d545269245eeb9dceca609e87544cebb7020a20

Contributor guide

No contributing guide indexed for this repository

Research direction

Read pkg/gem/gem.go lines 240-264 and the linked source context, then review the analyzer details about the range-loop pointer. Done means leaving the requested reaction classifying the instance as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.