github-vet / github-vet/rangeloop-pointer-findings
fholzer/go-quic-reverse-proxy: reverse_proxy.go; 23 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [fholzer/go-quic-reverse-proxy](https://www.github.com/fholzer/go-quic-reverse-proxy) at [reverse_proxy.go](https://github.com/fholzer/go-quic-reverse-proxy/blob/afd0ff595d16021017dfa9ebaedc954743dbab69/reverse_proxy.go#L85-L107)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable addr used in defer or goroutine at line 95
[Click here to see the code in its original context.](https://github.com/fholzer/go-quic-reverse-proxy/blob/afd0ff595d16021017dfa9ebaedc954743dbab69/reverse_proxy.go#L85-L107)
Click here to show the 23 line(s) of Go which triggered the analyzer.
```go
for _, addr := range s.Bindings {
pl, err := listenPacket(addr)
if err != nil {
panic(err)
}
go func() {
var err error
server := h2quic.Server{
Server: &http.Server{
Addr: addr,
Handler: handler,
TLSConfig: &tlsConfig,
},
}
err = server.Serve(pl)
if err != nil {
fmt.Println(err)
}
wg.Done()
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: afd0ff595d16021017dfa9ebaedc954743dbab69
Contributor guide
No contributing guide indexed for this repository
Research direction
Read reverse_proxy.go around lines 85-107, focusing on the goroutine started inside the Bindings loop and how addr is used. Determine whether the reported range-loop capture is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on this issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100