github-vet / github-vet/rangeloop-pointer-findings

tokenbankteam/tb_common: health/monitor.go; 9 LoC

Open
#16,947 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [tokenbankteam/tb_common](https://www.github.com/tokenbankteam/tb_common) at [health/monitor.go](https://github.com/tokenbankteam/tb_common/blob/165279c69f81ede4f9335d7b2263aaaaba447e13/health/monitor.go#L17-L25)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable addr used in defer or goroutine at line 21

[Click here to see the code in its original context.](https://github.com/tokenbankteam/tb_common/blob/165279c69f81ede4f9335d7b2263aaaaba447e13/health/monitor.go#L17-L25)

Click here to show the 9 line(s) of Go which triggered the analyzer.

```go
for _, addr := range binds {
log.Infof("start monitor listen: %v", addr)
go func(bind string) {
if err := http.ListenAndServe(bind, monitorServeMux); err != nil {
log.Errorf("http.ListenAndServe(\"%s\", monitorServeMux) error(%v)", addr, err)
panic(err)
}
}(addr)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 165279c69f81ede4f9335d7b2263aaaaba447e13

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with health/monitor.go lines 17-25 and the linked analyzer finding. Confirm whether the reported range-loop capture is a bug, then ensure the monitor's error logging uses the intended bind and the analyzer no longer reports this finding.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.