github-vet / github-vet/rangeloop-pointer-findings
SevereCloud/vksdk: events/events.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [SevereCloud/vksdk](https://www.github.com/SevereCloud/vksdk) at [events/events.go](https://github.com/SevereCloud/vksdk/blob/691e87e001d589843dc43441a2d4b2a82e8972ce/events/events.go#L257-L263)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable f used in defer or goroutine at line 259
[Click here to see the code in its original context.](https://github.com/SevereCloud/vksdk/blob/691e87e001d589843dc43441a2d4b2a82e8972ce/events/events.go#L257-L263)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for _, f := range fl.messageEvent {
if fl.goroutine {
go func() { f(ctx, obj) }()
} else {
f(ctx, obj)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 691e87e001d589843dc43441a2d4b2a82e8972ce
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with events/events.go lines 257-263 and the linked commit; inspect how f is used in the goroutine and compare the analyzer finding with the project's range-loop-capture guidance. When you determine whether this is a Bug, Mitigated, or Desirable Behavior, leave the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100