github-vet / github-vet/rangeloop-pointer-findings
SevereCloud/vksdk: events/events.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [SevereCloud/vksdk](https://www.github.com/SevereCloud/vksdk) at [events/events.go](https://github.com/SevereCloud/vksdk/blob/691e87e001d589843dc43441a2d4b2a82e8972ce/events/events.go#L504-L510)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable f used in defer or goroutine at line 506
[Click here to see the code in its original context.](https://github.com/SevereCloud/vksdk/blob/691e87e001d589843dc43441a2d4b2a82e8972ce/events/events.go#L504-L510)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for _, f := range fl.boardPostEdit {
if fl.goroutine {
go func() { f(ctx, obj) }()
} else {
f(ctx, obj)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 691e87e001d589843dc43441a2d4b2a82e8972ce
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at events/events.go lines 504-510 and inspect how the range over fl.boardPostEdit interacts with the goroutine branch. Confirm the analyzer's range-loop capture finding and verify that each asynchronous callback receives the intended function; done means the reported issue is addressed without changing the synchronous behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100