github-vet / github-vet/rangeloop-pointer-findings
pfnet-research/node-operation-controller: controllers/eviction_stragegy.go; 16 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [pfnet-research/node-operation-controller](https://www.github.com/pfnet-research/node-operation-controller) at [controllers/eviction_stragegy.go](https://github.com/pfnet-research/node-operation-controller/blob/773a4d0c15327ada43b00c3d8f3a1dfb797234e8/controllers/eviction_stragegy.go#L90-L105)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/pfnet-research/node-operation-controller/blob/773a4d0c15327ada43b00c3d8f3a1dfb797234e8/controllers/eviction_stragegy.go#L90-L105)
Click here to show the 16 line(s) of Go which triggered the analyzer.
```go
for _, pod := range pods {
s.log.Info("Deleting a Pod", "namespace", pod.Namespace, "name", pod.Name, "nodeName", pod.Spec.NodeName)
if err := s.client.Delete(context.Background(), &pod, opts...); err != nil {
if errors.IsNotFound(err) {
s.log.Info("Pod Not found. Skip deletion", "namespace", pod.Namespace, "name", pod.Name, "nodeName", pod.Spec.NodeName)
continue
}
s.log.Error(err, "Couldn't Delete Pod", "namespace", pod.Namespace, "name", pod.Name, "nodeName", pod.Spec.NodeName)
return false, err
}
if force {
s.eventRecorder.Eventf(&pod, corev1.EventTypeNormal, "ForceDeleted", `Node Operation "%s" force deleted a Pod`, nodeOp.Name)
} else {
s.eventRecorder.Eventf(&pod, corev1.EventTypeNormal, "Deleted", `Node Operation "%s" deleted a Pod`, nodeOp.Name)
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Eventf 5} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 773a4d0c15327ada43b00c3d8f3a1dfb797234e8
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.