github-vet / github-vet/rangeloop-pointer-findings
cswarm/ck8s: controller/pkg/controller/computer/computer_controller.go; 15 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [cswarm/ck8s](https://www.github.com/cswarm/ck8s) at [controller/pkg/controller/computer/computer_controller.go](https://github.com/cswarm/ck8s/blob/ae6b529a1263f97829c459e60d5a3e45f44ed7bc/controller/pkg/controller/computer/computer_controller.go#L149-L163)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/cswarm/ck8s/blob/ae6b529a1263f97829c459e60d5a3e45f44ed7bc/controller/pkg/controller/computer/computer_controller.go#L149-L163)
Click here to show the 15 line(s) of Go which triggered the analyzer.
```go
for _, pod := range computerpods.Items {
if pod.Status.AssignedComputer == c.Name {
log.Info("marking computerpod as pending due to computer being unready", "pod", pod.Name)
pod.Status.AssignedComputer = ""
pod.Status.Phase = core.PodPending
pod.Status.Reason = "ComputerUnready"
pod.Status.Message = "computer went unready"
err := r.client.Status().Patch(context.TODO(), &pod, &jsonPatcher{})
if err != nil {
log.Error(err, "failed to remove pod from unready node")
}
r.recorder.Eventf(&pod, core.EventTypeWarning, "ComputerUnready", "computer '%s' went unready", c.Name)
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Eventf 5} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ae6b529a1263f97829c459e60d5a3e45f44ed7bc
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.