github-vet / github-vet/rangeloop-pointer-findings

grpc-up-and-running/samples: ch05/cancellation/order-service/go/server/main.go; 4 LoC

Open
#16,815 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [grpc-up-and-running/samples](https://www.github.com/grpc-up-and-running/samples) at [ch05/cancellation/order-service/go/server/main.go](https://github.com/grpc-up-and-running/samples/blob/1f9de1e3efd98182883c93f36ad3a15039fe58f3/ch05/cancellation/order-service/go/server/main.go#L128-L131)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/grpc-up-and-running/samples/blob/1f9de1e3efd98182883c93f36ad3a15039fe58f3/ch05/cancellation/order-service/go/server/main.go#L128-L131)

Click here to show the 4 line(s) of Go which triggered the analyzer.

```go
for _, comb := range combinedShipmentMap {
log.Print("Shipping : " , comb.Id, " -> ", len(comb.OrdersList))
stream.Send(&comb)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Send 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1f9de1e3efd98182883c93f36ad3a15039fe58f3

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with ch05/cancellation/order-service/go/server/main.go at lines 128-131 and inspect the surrounding order-service cancellation flow. Determine whether passing comb to stream.Send from the range loop is a bug, mitigation, or desirable behavior, then classify the finding on the issue; done means the classification is supported by the code context.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.