github-vet / github-vet/rangeloop-pointer-findings
google/exposure-notifications-verification-server: pkg/database/migrations.go; 19 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [google/exposure-notifications-verification-server](https://www.github.com/google/exposure-notifications-verification-server) at [pkg/database/migrations.go](https://github.com/google/exposure-notifications-verification-server/blob/29d66d62689055fe85f27a5cf7701051ed5cb1f4/pkg/database/migrations.go#L431-L449)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to app was used in a composite literal at line 446
[Click here to see the code in its original context.](https://github.com/google/exposure-notifications-verification-server/blob/29d66d62689055fe85f27a5cf7701051ed5cb1f4/pkg/database/migrations.go#L431-L449)
Click here to show the 19 line(s) of Go which triggered the analyzer.
```go
for _, app := range apps {
// If the key has a preview, it's v2
if app.APIKeyPreview != "" {
continue
}
apiKeyPreview := app.APIKey[:6]
newAPIKey, err := db.GenerateAPIKeyHMAC(app.APIKey)
if err != nil {
return fmt.Errorf("failed to hmac %v: %w", app.Name, err)
}
app.APIKey = newAPIKey
app.APIKeyPreview = apiKeyPreview
if err := db.db.Save(&app).Error; err != nil {
return fmt.Errorf("failed to save %v: %w", app.Name, err)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 29d66d62689055fe85f27a5cf7701051ed5cb1f4
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.