github-vet / github-vet/rangeloop-pointer-findings

qshuai/cswm: controllers/move.go; 6 LoC

Open
#16,803 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [qshuai/cswm](https://www.github.com/qshuai/cswm) at [controllers/move.go](https://github.com/qshuai/cswm/blob/f52074289ee137963c639e06eb4b8049f4f0a32d/controllers/move.go#L118-L123)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to item is reassigned at line 121

[Click here to see the code in its original context.](https://github.com/qshuai/cswm/blob/f52074289ee137963c639e06eb4b8049f4f0a32d/controllers/move.go#L118-L123)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, item := range pool_user {
//此处有一定的隐患
if len(item.PoolName) > 2 && item.PoolName != c.GetString("store_from") {
move.Response = &item
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f52074289ee137963c639e06eb4b8049f4f0a32d

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with controllers/move.go at lines 118-123 in commit f52074289ee137963c639e06eb4b8049f4f0a32d and inspect the reported range-loop pointer finding in its controller context. Determine whether the selected pool item can be represented incorrectly; done means the behavior is corrected or the finding is shown to be intentional and classified accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.