github-vet / github-vet/rangeloop-pointer-findings

gyf304/svpn: mnat.go; 18 LoC

Open
#16,794 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gyf304/svpn](https://www.github.com/gyf304/svpn) at [mnat.go](https://github.com/gyf304/svpn/blob/480411c5281985e3c8cb4baf5afba831f61987bc/mnat.go#L283-L300)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to privateAddr was used in a composite literal at line 289

[Click here to see the code in its original context.](https://github.com/gyf304/svpn/blob/480411c5281985e3c8cb4baf5afba831f61987bc/mnat.go#L283-L300)

Click here to show the 18 line(s) of Go which triggered the analyzer.

```go
for privateAddr, publicAddrs := range mNAT.privateToPublic {
for publicAddr, pinned := range publicAddrs {
if !onlyPinned || pinned {
if dir {
entries = append(entries, staticNATEntry{
staticAddrFromAddr(&publicAddr),
staticAddrFromAddr(&privateAddr),
})
} else {
fmt.Println(privateAddr, publicAddr)
entries = append(entries, staticNATEntry{
staticAddrFromAddr(&privateAddr),
staticAddrFromAddr(&publicAddr),
})
}
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 480411c5281985e3c8cb4baf5afba831f61987bc

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.