github-vet / github-vet/rangeloop-pointer-findings

clementauger/whisper: internal/upload/store.go; 7 LoC

Open
#16,760 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [clementauger/whisper](https://www.github.com/clementauger/whisper) at [internal/upload/store.go](https://github.com/clementauger/whisper/blob/8ea1ed1e42f52a2d150e2f873542b375be178c73/internal/upload/store.go#L139-L145)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to up is reassigned at line 141

[Click here to see the code in its original context.](https://github.com/clementauger/whisper/blob/8ea1ed1e42f52a2d150e2f873542b375be178c73/internal/upload/store.go#L139-L145)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for _, up := range s.items {
if oldest == nil {
oldest = &up
} else if up.CreatedAt.Before(oldest.CreatedAt) {
oldest = &up
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 8ea1ed1e42f52a2d150e2f873542b375be178c73

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect internal/upload/store.go at lines 139-145 and compare the range-loop pointer usage with the analyzer report. Determine whether the referenced loop variable can produce incorrect oldest-item behavior, then leave the requested reaction classifying it as a Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.