github-vet / github-vet/rangeloop-pointer-findings

kubernetes/kube-state-metrics: internal/store/job.go; 23 LoC

Open
#16,734 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kubernetes/kube-state-metrics](https://www.github.com/kubernetes/kube-state-metrics) at [internal/store/job.go](https://github.com/kubernetes/kube-state-metrics/blob/fa59824e69868d1136c77e672353aa351bdd74a3/internal/store/job.go#L185-L207)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to condition was used in a composite literal at line 189

[Click here to see the code in its original context.](https://github.com/kubernetes/kube-state-metrics/blob/fa59824e69868d1136c77e672353aa351bdd74a3/internal/store/job.go#L185-L207)

Click here to show the 23 line(s) of Go which triggered the analyzer.

```go
for _, condition := range j.Status.Conditions {
if condition.Type == v1batch.JobFailed {
reasonKnown := false
for _, reason := range jobFailureReasons {
reasonKnown = reasonKnown || failureReason(&condition, reason)

// for known reasons
ms = append(ms, &metric.Metric{
LabelKeys: []string{"reason"},
LabelValues: []string{reason},
Value: boolFloat64(failureReason(&condition, reason)),
})
}
// for unknown reasons
if !reasonKnown {
ms = append(ms, &metric.Metric{
LabelKeys: []string{"reason"},
LabelValues: []string{""},
Value: float64(j.Status.Failed),
})
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: fa59824e69868d1136c77e672353aa351bdd74a3

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.