github-vet / github-vet/rangeloop-pointer-findings

carltraveler/oscore: core/oscore_api.go; 9 LoC

Open
#16,716 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [carltraveler/oscore](https://www.github.com/carltraveler/oscore) at [core/oscore_api.go](https://github.com/carltraveler/oscore/blob/c2730b06bf7ef8377d1f35cdc03bdf2180d12920/core/oscore_api.go#L515-L523)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to s was used in a composite literal at line 517

[Click here to see the code in its original context.](https://github.com/carltraveler/oscore/blob/c2730b06bf7ef8377d1f35cdc03bdf2180d12920/core/oscore_api.go#L515-L523)

Click here to show the 9 line(s) of Go which triggered the analyzer.

```go
for _, s := range param.Specs {
s.ApiId = info.ApiId
err := dao.DefOscoreApiDB.InsertSpecifications(tx, []*tables.Specifications{&s})
if err != nil {
errl = err
log.Debugf("PublishAPIHandleCore.8. %s", err)
return err
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c2730b06bf7ef8377d1f35cdc03bdf2180d12920

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect core/oscore_api.go at lines 515-523 and read the surrounding code to understand how the range-loop value is passed to InsertSpecifications. Determine whether the analyzer's reported reference to s represents a bug, mitigated behavior, or desirable behavior, then classify the finding using the three reactions described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.