github-vet / github-vet/rangeloop-pointer-findings

jaygno/dns2host: dnsclient_unix.go; 19 LoC

Open
#16,712 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [jaygno/dns2host](https://www.github.com/jaygno/dns2host) at [dnsclient_unix.go](https://github.com/jaygno/dns2host/blob/50784c29b7a83d3f4c4fbd624f41c6d4ab3fe3f5/dnsclient_unix.go#L58-L76)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable fqdn used in defer or goroutine at line 61

[Click here to see the code in its original context.](https://github.com/jaygno/dns2host/blob/50784c29b7a83d3f4c4fbd624f41c6d4ab3fe3f5/dnsclient_unix.go#L58-L76)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for _, fqdn := range nameList(name) {
for _, qtype := range qtypes {
go func(qtype uint16) {
_, rrs, err := tryOneName(server, fqdn, qtype)
lane <- racer{rrs, err}
}(qtype)
}
for range qtypes {
racer := <-lane
if racer.error != nil {
lastErr = racer.error
continue
}
addrs = append(addrs, addrRecordList(racer.rrs)...)
}
if len(addrs) > 0 {
break
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 50784c29b7a83d3f4c4fbd624f41c6d4ab3fe3f5

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.