github-vet / github-vet/rangeloop-pointer-findings

xoreo/mcserver-backend: types/serverdb.go; 18 LoC

Open
#16,599 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [xoreo/mcserver-backend](https://www.github.com/xoreo/mcserver-backend) at [types/serverdb.go](https://github.com/xoreo/mcserver-backend/blob/98571d4a4dbc62c5a1c4060f80642d6eb9e509ec/types/serverdb.go#L84-L101)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to currentServer is reassigned at line 88

[Click here to see the code in its original context.](https://github.com/xoreo/mcserver-backend/blob/98571d4a4dbc62c5a1c4060f80642d6eb9e509ec/types/serverdb.go#L84-L101)

Click here to show the 18 line(s) of Go which triggered the analyzer.

```go
for _, currentServer := range db.Servers {
// If hash is used instead of
if hash != "" { // Then oldServer should also be nil. But if it isn't, hash is preferred
if serverMatch(currentServer, hash) {
oldServer = ¤tServer
exists = true
break
}
} else if hash == "" {
// If oldServer is used instead of the old server hash
if currentServer.Hash.String() == oldServer.Hash.String() {
exists = true
break
}
} else {
return errors.New("bad arguments to UpdateServer call")
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 98571d4a4dbc62c5a1c4060f80642d6eb9e509ec

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.