github-vet / github-vet/rangeloop-pointer-findings

gridgentoo/VictoriaMetrics-Operator: controllers/vmrule_controller.go; 20 LoC

Open
#16,596 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gridgentoo/VictoriaMetrics-Operator](https://www.github.com/gridgentoo/VictoriaMetrics-Operator) at [controllers/vmrule_controller.go](https://github.com/gridgentoo/VictoriaMetrics-Operator/blob/4ed3ffb2fcfbd19c417782ab256b8446b4ce8e4b/controllers/vmrule_controller.go#L69-L88)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to vmalert is reassigned at line 72

[Click here to see the code in its original context.](https://github.com/gridgentoo/VictoriaMetrics-Operator/blob/4ed3ffb2fcfbd19c417782ab256b8446b4ce8e4b/controllers/vmrule_controller.go#L69-L88)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for _, vmalert := range alertMngs.Items {
reqLogger.WithValues("vmalert", vmalert.Name)
reqLogger.Info("reconciling vmalert rules")
currVMAlert := &vmalert

maps, err := factory.CreateOrUpdateRuleConfigMaps(ctx, currVMAlert, r)
if err != nil {
reqLogger.Error(err, "cannot update rules configmaps")
return ctrl.Result{}, err
}
reqLogger.Info("created rules maps count", "count", len(maps))

_, err = factory.CreateOrUpdateVMAlert(ctx, currVMAlert, r, r.BaseConf, maps)
if err != nil {
reqLogger.Error(err, "cannot trigger vmalert update, after rules changing")
return ctrl.Result{}, nil
}
reqLogger.Info("reconciled vmalert rules")

}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 4ed3ffb2fcfbd19c417782ab256b8446b4ce8e4b

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with controllers/vmrule_controller.go at lines 69-88 and inspect the analyzer's warning about the vmalert reference being reassigned at line 72. Determine whether the loop's behavior is incorrect and classify the finding; done means the behavior is confirmed as a bug or the analyzer finding is shown to be benign.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.