github-vet / github-vet/rangeloop-pointer-findings
gridgentoo/VictoriaMetrics-Operator: controllers/vmpodscrape_controller.go; 11 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [gridgentoo/VictoriaMetrics-Operator](https://www.github.com/gridgentoo/VictoriaMetrics-Operator) at [controllers/vmpodscrape_controller.go](https://github.com/gridgentoo/VictoriaMetrics-Operator/blob/4ed3ffb2fcfbd19c417782ab256b8446b4ce8e4b/controllers/vmpodscrape_controller.go#L66-L76)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to vmagent is reassigned at line 69
[Click here to see the code in its original context.](https://github.com/gridgentoo/VictoriaMetrics-Operator/blob/4ed3ffb2fcfbd19c417782ab256b8446b4ce8e4b/controllers/vmpodscrape_controller.go#L66-L76)
Click here to show the 11 line(s) of Go which triggered the analyzer.
```go
for _, vmagent := range vmAgentInstances.Items {
reqLogger = reqLogger.WithValues("vmagent", vmagent.Name)
reqLogger.Info("reconciling podscrape for vmagent")
currentVMagent := &vmagent
recon, err := factory.CreateOrUpdateVMAgent(ctx, currentVMagent, r, r.BaseConf)
if err != nil {
reqLogger.Error(err, "cannot create or update vmagent")
return recon, err
}
reqLogger.Info("reconciled vmagent")
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 4ed3ffb2fcfbd19c417782ab256b8446b4ce8e4b
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.