github-vet / github-vet/rangeloop-pointer-findings

wfrank/qtools: cmd/qrsunix/main.go; 5 LoC

Open
#16,581 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [wfrank/qtools](https://www.github.com/wfrank/qtools) at [cmd/qrsunix/main.go](https://github.com/wfrank/qtools/blob/0dde5cba6ea03894edf14f19beeabda1a8170b43/cmd/qrsunix/main.go#L76-L80)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to set is reassigned at line 78

[Click here to see the code in its original context.](https://github.com/wfrank/qtools/blob/0dde5cba6ea03894edf14f19beeabda1a8170b43/cmd/qrsunix/main.go#L76-L80)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, set := range allRefSets {
if name := set.Name; strings.HasPrefix(name, unixRefSetPrefix) {
unixRefSets[name] = &set
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0dde5cba6ea03894edf14f19beeabda1a8170b43

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect cmd/qrsunix/main.go around lines 76-80 and the linked commit to understand how the range-loop variable is referenced. Decide whether the analyzer finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.