github-vet / github-vet/rangeloop-pointer-findings

gincmf-team/gincmf: app/migrate/role.go; 3 LoC

Open
#16,579 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gincmf-team/gincmf](https://www.github.com/gincmf-team/gincmf) at [app/migrate/role.go](https://github.com/gincmf-team/gincmf/blob/e630709c527aaf1e11ccf7d92c17c7f9a5682624/app/migrate/role.go#L38-L40)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/gincmf-team/gincmf/blob/e630709c527aaf1e11ccf7d92c17c7f9a5682624/app/migrate/role.go#L38-L40)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _,v := range role{
cmf.NewDb().Where(model.Role{Name: v.Name}).FirstOrCreate(&v)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {FirstOrCreate 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e630709c527aaf1e11ccf7d92c17c7f9a5682624

Contributor guide

No contributing guide indexed for this repository

Research direction

Read app/migrate/role.go at lines 38-40 and inspect how the range variable v is passed to FirstOrCreate. Compare the analyzer report with the intended role migration behavior; done means deciding whether this is a Bug, Mitigated, or Desirable Behavior finding and leaving the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.