github-vet / github-vet/rangeloop-pointer-findings

jiten-thakkar/CS6963: src/lab1_mapreduce/master.go; 25 LoC

Open
#16,574 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [jiten-thakkar/CS6963](https://www.github.com/jiten-thakkar/CS6963) at [src/lab1_mapreduce/master.go](https://github.com/jiten-thakkar/CS6963/blob/0e93608d1c84757da007dec801fdeb0bda6ae498/src/lab1_mapreduce/master.go#L60-L84)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable v used in defer or goroutine at line 71

[Click here to see the code in its original context.](https://github.com/jiten-thakkar/CS6963/blob/0e93608d1c84757da007dec801fdeb0bda6ae498/src/lab1_mapreduce/master.go#L60-L84)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for v := range mapTobeDoneChannel {

// DoMap(i, mr.file, mr.nReduce, Map)
tempJobParams := v
go func() {
var availWorkerAddress string
availWorkerAddress = availWorkersQueue.getWorker()
rep := DoJobReply{}
ok := call(availWorkerAddress, "Worker.DoJob", &tempJobParams, &rep)
if ok == true {
//fmt.Println("map job done job number: ", tempJobParams.JobNumber)
mapJobsDoneChannel <- v
availWorkersQueue.addWorker(availWorkerAddress)
//fmt.Println("cap: %v len: %v nmap: %v", cap(reduceJobsDoneChannel), len(reduceJobsDoneChannel), mr.nMap)
if len(mapJobsDoneChannel) == mr.nMap {
log.Println("map jobs done")
mapJobsDone <- true
}
} else {
//fmt.Println("map job failed job number: ", v.JobNumber)
//fmt.Println("error: ", ok)
mapTobeDoneChannel <- tempJobParams
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0e93608d1c84757da007dec801fdeb0bda6ae498

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.