github-vet / github-vet/rangeloop-pointer-findings
isdrchan/discuz-crawler: engine/concurrent.go; 4 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [isdrchan/discuz-crawler](https://www.github.com/isdrchan/discuz-crawler) at [engine/concurrent.go](https://github.com/isdrchan/discuz-crawler/blob/dfe787b26227b398b74fe808ba65ece0a7e0fcb2/engine/concurrent.go#L34-L37)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable request used in defer or goroutine at line 36
[Click here to see the code in its original context.](https://github.com/isdrchan/discuz-crawler/blob/dfe787b26227b398b74fe808ba65ece0a7e0fcb2/engine/concurrent.go#L34-L37)
Click here to show the 4 line(s) of Go which triggered the analyzer.
```go
for _, request := range result.Requests {
log.Printf("request:%v", request)
go func() { in <- request }()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: dfe787b26227b398b74fe808ba65ece0a7e0fcb2
Contributor guide
No contributing guide indexed for this repository
Research direction
Read engine/concurrent.go at lines 34-37 and the linked analyzer context first. Decide whether the reported range-loop variable use in the goroutine is a bug, mitigated, or desirable behavior, then record one of those classifications as a reaction; the task is done when the classification is recorded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100