github-vet / github-vet/rangeloop-pointer-findings

SevereCloud/vksdk: events/events.go; 7 LoC

Open
#16,542 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [SevereCloud/vksdk](https://www.github.com/SevereCloud/vksdk) at [events/events.go](https://github.com/SevereCloud/vksdk/blob/691e87e001d589843dc43441a2d4b2a82e8972ce/events/events.go#L803-L809)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable f used in defer or goroutine at line 805

[Click here to see the code in its original context.](https://github.com/SevereCloud/vksdk/blob/691e87e001d589843dc43441a2d4b2a82e8972ce/events/events.go#L803-L809)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for _, f := range fl.donutSubscriptionCreate {
if fl.goroutine {
go func() { f(ctx, obj) }()
} else {
f(ctx, obj)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 691e87e001d589843dc43441a2d4b2a82e8972ce

Contributor guide

No contributing guide indexed for this repository

Research direction

Read events/events.go around lines 803-809 and inspect the goroutine closure using the range-loop variable f. Compare the analyzer warning with the surrounding subscription dispatch behavior and determine whether the captured callback can be incorrect. Done means leaving the appropriate Bug, Mitigated, or Desirable Behavior reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.