github-vet / github-vet/rangeloop-pointer-findings

kohkimakimoto/essh: essh/essh.go; 19 LoC

Open
#16,521 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kohkimakimoto/essh](https://www.github.com/kohkimakimoto/essh) at [essh/essh.go](https://github.com/kohkimakimoto/essh/blob/361a401b475b91004a53c7b4e912f67b24ab27c0/essh/essh.go#L940-L958)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable i used in defer or goroutine at line 944

[Click here to see the code in its original context.](https://github.com/kohkimakimoto/essh/blob/361a401b475b91004a53c7b4e912f67b24ab27c0/essh/essh.go#L940-L958)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for i, host := range hosts {
if task.Parallel {
wg.Add(1)
go func(host *Host) {
err := runRemoteTaskScript(config, task, host, hosts, stdinChs[i], m)
if err != nil {
fmt.Fprintf(os.Stderr, color.FgRB("essh error: %v\n", err))
panic(err)
}

wg.Done()
}(host)
} else {
err := runRemoteTaskScript(config, task, host, hosts, stdinChs[i], m)
if err != nil {
return err
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 361a401b475b91004a53c7b4e912f67b24ab27c0

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with essh/essh.go lines 940-958 and inspect how the range-loop variable i is used inside the parallel goroutine and the non-parallel path. Determine whether the analyzer warning represents a real bug or desirable behavior, then classify the issue accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.