github-vet / github-vet/rangeloop-pointer-findings

lxc/lxd: lxd/storage_volumes_snapshot.go; 37 LoC

Open
#16,486 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [lxc/lxd](https://www.github.com/lxc/lxd) at [lxd/storage_volumes_snapshot.go](https://github.com/lxc/lxd/blob/bf9cd0f88f0f68e2620676f9457b07515caf8cf5/lxd/storage_volumes_snapshot.go#L740-L776)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable v used in defer or goroutine at line 743

[Click here to see the code in its original context.](https://github.com/lxc/lxd/blob/bf9cd0f88f0f68e2620676f9457b07515caf8cf5/lxd/storage_volumes_snapshot.go#L740-L776)

Click here to show the 37 line(s) of Go which triggered the analyzer.

```go
for _, v := range volumes {
ch := make(chan error)
go func() {
snapshotName, err := volumeDetermineNextSnapshotName(d, v, "snap%d")
if err != nil {
logger.Error("Error retrieving next snapshot name", log.Ctx{"err": err, "volume": v})
ch <- nil
return
}

expiry, err := shared.GetSnapshotExpiry(time.Now(), v.Config["snapshots.expiry"])
if err != nil {
logger.Error("Error getting expiry date", log.Ctx{"err": err, "volume": v})
ch <- nil
return
}

pool, err := storagePools.GetPoolByName(d.State(), v.PoolName)
if err != nil {
logger.Error("Error retrieving pool", log.Ctx{"err": err, "pool": v.PoolName})
ch <- nil
return
}

err = pool.CreateCustomVolumeSnapshot(v.ProjectName, v.Name, snapshotName, expiry, nil)
if err != nil {
logger.Error("Error creating volume snapshot", log.Ctx{"err": err, "volume": v})
}

ch <- nil
}()
select {
case <-ctx.Done():
return nil
case <-ch:
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: bf9cd0f88f0f68e2620676f9457b07515caf8cf5

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.