github-vet / github-vet/rangeloop-pointer-findings
anthdm/hbbft: simulation/main.go; 18 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [anthdm/hbbft](https://www.github.com/anthdm/hbbft) at [simulation/main.go](https://github.com/anthdm/hbbft/blob/0826ffdcf567629942544b7382433aacedaf3fb3/simulation/main.go#L108-L125)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable tx used in defer or goroutine at line 120
[Click here to see the code in its original context.](https://github.com/anthdm/hbbft/blob/0826ffdcf567629942544b7382433aacedaf3fb3/simulation/main.go#L108-L125)
Click here to show the 18 line(s) of Go which triggered the analyzer.
```go
for _, tx := range txx {
if s.verifyTransaction(tx) {
s.lock.Lock()
s.mempool[string(tx.Hash())] = tx
s.lock.Unlock()
// Add this transaction to the hbbft buffer.
s.hb.AddTransaction(tx)
// relay the transaction to all other nodes in the network.
go func() {
for i := 0; i < len(s.hb.Nodes); i++ {
if uint64(i) != s.hb.ID {
relayCh <- tx
}
}
}()
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 0826ffdcf567629942544b7382433aacedaf3fb3
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.