github-vet / github-vet/rangeloop-pointer-findings

twitchyliquid64/raspberry-box: interpreter/env_net.go; 3 LoC

Open
#16,465 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [twitchyliquid64/raspberry-box](https://www.github.com/twitchyliquid64/raspberry-box) at [interpreter/env_net.go](https://github.com/twitchyliquid64/raspberry-box/blob/1b8d3b4909e49c9631ed7948759b81fbeefbc5f4/interpreter/env_net.go#L501-L503)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to s was used in a composite literal at line 502

[Click here to see the code in its original context.](https://github.com/twitchyliquid64/raspberry-box/blob/1b8d3b4909e49c9631ed7948759b81fbeefbc5f4/interpreter/env_net.go#L501-L503)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, s := range p.Conf.Sections {
out = append(out, &DHCPProfileProxy{Profile: &s})
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1b8d3b4909e49c9631ed7948759b81fbeefbc5f4

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in interpreter/env_net.go at lines 501-503 and inspect how p.Conf.Sections and the DHCPProfileProxy values are used. Determine whether taking the address of the range variable is problematic in this context, then classify the finding by leaving the appropriate reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.