github-vet / github-vet/rangeloop-pointer-findings

cnrancher/octopus-api-server: pkg/apis/octopusapi.cattle.io/v1alpha1/zz_generated_deepcopy.go; 17 LoC

Open
#16,438 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [cnrancher/octopus-api-server](https://www.github.com/cnrancher/octopus-api-server) at [pkg/apis/octopusapi.cattle.io/v1alpha1/zz_generated_deepcopy.go](https://github.com/cnrancher/octopus-api-server/blob/c8f0aa8e59881eeb02480a230530ade1d96d5683/pkg/apis/octopusapi.cattle.io/v1alpha1/zz_generated_deepcopy.go#L421-L437)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 426

[Click here to see the code in its original context.](https://github.com/cnrancher/octopus-api-server/blob/c8f0aa8e59881eeb02480a230530ade1d96d5683/pkg/apis/octopusapi.cattle.io/v1alpha1/zz_generated_deepcopy.go#L421-L437)

Click here to show the 17 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal []*ChartVersion
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(ChartVersions, len(*in))
for i := range *in {
if (*in)[i] != nil {
in, out := &(*in)[i], &(*out)[i]
*out = new(ChartVersion)
(*in).DeepCopyInto(*out)
}
}
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c8f0aa8e59881eeb02480a230530ade1d96d5683

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading pkg/apis/octopusapi.cattle.io/v1alpha1/zz_generated_deepcopy.go at lines 421-437 for commit c8f0aa8. Inspect the analyzer's reported reassignment in the generated deepcopy logic and determine whether it represents a real bug, mitigated behavior, or desirable behavior; the issue is complete when the finding is classified.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.