github-vet / github-vet/rangeloop-pointer-findings

robphoenix/concurrency-made-easy: 03-acquire-semaphores/main.go; 10 LoC

Open
#16,346 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [robphoenix/concurrency-made-easy](https://www.github.com/robphoenix/concurrency-made-easy) at [03-acquire-semaphores/main.go](https://github.com/robphoenix/concurrency-made-easy/blob/1082a986bcdcd64f36864703474f15bb197c66cf/03-acquire-semaphores/main.go#L29-L38)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable repo used in defer or goroutine at line 33

[Click here to see the code in its original context.](https://github.com/robphoenix/concurrency-made-easy/blob/1082a986bcdcd64f36864703474f15bb197c66cf/03-acquire-semaphores/main.go#L29-L38)

Click here to show the 10 line(s) of Go which triggered the analyzer.

```go
for _, repo := range repos {
go func() {
defer wg.Done()
sem <- 1
if err := fetch(repo); err != nil {
errChan <- err
}
<-sem
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1082a986bcdcd64f36864703474f15bb197c66cf

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with 03-acquire-semaphores/main.go at lines 29-38 and review the analyzer report about the range-loop variable repo being used in the goroutine. Check the surrounding code for the reported behavior and any additional issue the analyzer may identify. Done means leaving the appropriate reaction to classify it as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.