github-vet / github-vet/rangeloop-pointer-findings

ovh/cds: engine/api/workflow/factory_dao.go; 8 LoC

Open
#16,324 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ovh/cds](https://www.github.com/ovh/cds) at [engine/api/workflow/factory_dao.go](https://github.com/ovh/cds/blob/22dd2da3fdf6357bd4053936cccef93f18090586/engine/api/workflow/factory_dao.go#L457-L464)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to wti is reassigned at line 459

[Click here to see the code in its original context.](https://github.com/ovh/cds/blob/22dd2da3fdf6357bd4053936cccef93f18090586/engine/api/workflow/factory_dao.go#L457-L464)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for _, wti := range wtis {
if wti.WorkflowID != nil && w.ID == *wti.WorkflowID {
w.TemplateInstance = &wti
w.FromTemplate = fmt.Sprintf("%s@%d", wti.Template.Path(), wti.WorkflowTemplateVersion)
w.TemplateUpToDate = wti.Template.Version == wti.WorkflowTemplateVersion
break
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 22dd2da3fdf6357bd4053936cccef93f18090586

Contributor guide

No contributing guide indexed for this repository

Research direction

Read engine/api/workflow/factory_dao.go around lines 457-464 and inspect how the workflow template instance is used after the range loop. Determine whether the reported reference to wti causes incorrect behavior, then classify the finding with the requested Bug, Mitigated, or Desirable Behavior reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.