github-vet / github-vet/rangeloop-pointer-findings

kaimixu/kbang: robot/robot.go; 26 LoC

Open
#16,314 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kaimixu/kbang](https://www.github.com/kaimixu/kbang) at [robot/robot.go](https://github.com/kaimixu/kbang/blob/665fff8ca0f1ef9f91c4443a3dd3459512410d79/robot/robot.go#L66-L91)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to reqC was used in a composite literal at line 87

[Click here to see the code in its original context.](https://github.com/kaimixu/kbang/blob/665fff8ca0f1ef9f91c4443a3dd3459512410d79/robot/robot.go#L66-L91)

Click here to show the 26 line(s) of Go which triggered the analyzer.

```go
for _, reqC := range this.httpConf.Request {
method := strings.ToUpper(reqC.Method)
if method == "" {
continue
}
if method != "GET" && method != "POST" {
return errors.New("invalid http method")
}

r, err := http.NewRequest(method, reqC.Url, nil)
if err != nil {
return err
}
if len(reqC.ContentType) != 0 {
r.Header.Set("Content-Type", reqC.ContentType)
}
if len(header) == 2 {
r.Header.Add(header[0], header[1])
}

for i := 0; i < reqC.Weight; i++ {
reqs = append(reqs, &request{preq:r, conf:&reqC})
}

this.weight += reqC.Weight
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 665fff8ca0f1ef9f91c4443a3dd3459512410d79

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with robot/robot.go lines 66-91 and inspect how the request entries are stored and later used. Check whether each appended request retains the intended loop entry or the same range variable reference, then compare the behavior with the analyzer report. Done means reacting to classify the finding as a bug, mitigated, or desirable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.