github-vet / github-vet/rangeloop-pointer-findings
BryanSLam/discord-bot: commander.go; 19 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [BryanSLam/discord-bot](https://www.github.com/BryanSLam/discord-bot) at [commander.go](https://github.com/BryanSLam/discord-bot/blob/535303ff6d6b516a9539c099935570be2f2090cb/commander.go#L54-L72)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable c used in defer or goroutine at line 60
[Click here to see the code in its original context.](https://github.com/BryanSLam/discord-bot/blob/535303ff6d6b516a9539c099935570be2f2090cb/commander.go#L54-L72)
Click here to show the 19 line(s) of Go which triggered the analyzer.
```go
for _, c := range commands {
if c.Match(m.Content) {
go func() {
defer func() {
if err := recover(); err != nil {
logger.Write([]byte(util.MentionMaintainers(maintainers) + " an error has occurred"))
logger.Warn(fmt.Sprintln("function", util.FuncName(c.Fn), "failed:", err))
}
}()
// TODO: use context and change command to an interface instead of struct
mm := map[string]interface{}{}
mm["messageCreate"] = m
c.Fn(drw, logger, mm)
}()
return
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 535303ff6d6b516a9539c099935570be2f2090cb
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with commander.go lines 54-72 at commit 535303ff6d6b516a9539c099935570be2f2090cb and inspect the surrounding command-dispatch context. Determine whether the reported range-loop capture is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction; no test file is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100