github-vet / github-vet/rangeloop-pointer-findings
quay/claircore: internal/indexer/postgres/affectedmanifest.go; 15 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [quay/claircore](https://www.github.com/quay/claircore) at [internal/indexer/postgres/affectedmanifest.go](https://github.com/quay/claircore/blob/def91aca154c5adb3ce3560998f6a6dbac66bb7c/internal/indexer/postgres/affectedmanifest.go#L128-L142)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to pkg is reassigned at line 129
[Click here to see the code in its original context.](https://github.com/quay/claircore/blob/def91aca154c5adb3ce3560998f6a6dbac66bb7c/internal/indexer/postgres/affectedmanifest.go#L128-L142)
Click here to show the 15 line(s) of Go which triggered the analyzer.
```go
for _, pkg := range pkgsToFilter {
pr.Package = &pkg
match, err := om.Vulnerable(ctx, &pr, &v)
if err != nil {
return nil, err
}
if match {
p := pkg // make a copy, or else you'll get a stale reference later
filteredRecords = append(filteredRecords, claircore.IndexRecord{
Package: &p,
Distribution: pr.Distribution,
Repository: pr.Repository,
})
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: def91aca154c5adb3ce3560998f6a6dbac66bb7c
Contributor guide
No contributing guide indexed for this repository
Research direction
Read internal/indexer/postgres/affectedmanifest.go at lines 128-142 and review the linked analyzer finding about the range-loop variable. Compare the reported reference behavior with the repository's classification guidance, then leave the appropriate reaction when the finding is understood; no pull request or test is mentioned in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100