github-vet / github-vet/rangeloop-pointer-findings

mogaika/god_of_war_browser: drivers/toc/toc.go; 9 LoC

Open
#16,259 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [mogaika/god_of_war_browser](https://www.github.com/mogaika/god_of_war_browser) at [drivers/toc/toc.go](https://github.com/mogaika/god_of_war_browser/blob/09779e4f4e74712240ea457f64076c9d048bc26d/drivers/toc/toc.go#L92-L100)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to policy is reassigned at line 93

[Click here to see the code in its original context.](https://github.com/mogaika/god_of_war_browser/blob/09779e4f4e74712240ea457f64076c9d048bc26d/drivers/toc/toc.go#L92-L100)

Click here to show the 9 line(s) of Go which triggered the analyzer.

```go
for _, policy := range defaultTocNamePair {
t.namingPolicy = &policy
if _, err = t.openTocFile(); err == nil {
log.Printf("[toc] Detected toc file %q", policy.TocName)
return nil
} else {
log.Printf("[toc] WARNING: Error opening possible toc file %q: %v", policy.TocName, err)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 09779e4f4e74712240ea457f64076c9d048bc26d

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with drivers/toc/toc.go lines 92-100 and the analyzer message about reassignment of policy. Check whether the range variable reference remains valid across iterations, then classify the finding as a bug, mitigated issue, or desirable behavior as requested.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.