github-vet / github-vet/rangeloop-pointer-findings
jaegertracing/jaeger: cmd/anonymizer/main.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [jaegertracing/jaeger](https://www.github.com/jaegertracing/jaeger) at [cmd/anonymizer/main.go](https://github.com/jaegertracing/jaeger/blob/68acf65e5f12c3e0c2232252de6067e2a8d5f364/cmd/anonymizer/main.go#L71-L73)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to span was used in a composite literal at line 72
[Click here to see the code in its original context.](https://github.com/jaegertracing/jaeger/blob/68acf65e5f12c3e0c2232252de6067e2a8d5f364/cmd/anonymizer/main.go#L71-L73)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, span := range spans {
writer.WriteSpan(&span)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 68acf65e5f12c3e0c2232252de6067e2a8d5f364
Contributor guide
No contributing guide indexed for this repository
Research direction
Read cmd/anonymizer/main.go around lines 71-73 and inspect how the range variable span is passed to writer.WriteSpan. Compare the usage with the analyzer guidance, then leave the requested reaction classifying the finding as Bug, Mitigated, or Desirable Behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100