github-vet / github-vet/rangeloop-pointer-findings
datatogether/task_mgmt: tasks/task.go; 21 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [datatogether/task_mgmt](https://www.github.com/datatogether/task_mgmt) at [tasks/task.go](https://github.com/datatogether/task_mgmt/blob/a3f3dabe49725d6d7d47bd35a186c9f606a227c9/tasks/task.go#L192-L212)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to p is reassigned at line 196
[Click here to see the code in its original context.](https://github.com/datatogether/task_mgmt/blob/a3f3dabe49725d6d7d47bd35a186c9f606a227c9/tasks/task.go#L192-L212)
Click here to show the 21 line(s) of Go which triggered the analyzer.
```go
for p := range pc {
// TODO - log progress and pipe out of this func
// so others can listen in for updates
// fmt.Println(p.String())
task.Progress = &p
tc <- task
if p.Error != nil {
task.Error = p.Error.Error()
now := time.Now()
task.Failed = &now
go task.Save(store)
return p.Error
}
if p.Done {
now := time.Now()
task.Succeeded = &now
go task.Save(store)
return nil
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: a3f3dabe49725d6d7d47bd35a186c9f606a227c9
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.