github-vet / github-vet/rangeloop-pointer-findings

Ahmadposten/DC-OS-autoscaling: src/dcosautoscaling/application.go; 12 LoC

Open
#16,229 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Ahmadposten/DC-OS-autoscaling](https://www.github.com/Ahmadposten/DC-OS-autoscaling) at [src/dcosautoscaling/application.go](https://github.com/Ahmadposten/DC-OS-autoscaling/blob/b566a1230d5d20d5605d582067f6fa6a7cc66b75/src/dcosautoscaling/application.go#L250-L261)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable slave used in defer or goroutine at line 252

[Click here to see the code in its original context.](https://github.com/Ahmadposten/DC-OS-autoscaling/blob/b566a1230d5d20d5605d582067f6fa6a7cc66b75/src/dcosautoscaling/application.go#L250-L261)

Click here to show the 12 line(s) of Go which triggered the analyzer.

```go
for _, slave := range a.Slaves {
go func(wg *sync.WaitGroup) {
cpuUsage, memoryUsage, err := GetDeltas(slave)
if err != nil {
wg.Done()
} else {
cpuValues = append(cpuValues, cpuUsage)
memValues = append(memValues, memoryUsage)
wg.Done()
}
}(&wg)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: b566a1230d5d20d5605d582067f6fa6a7cc66b75

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing src/dcosautoscaling/application.go at lines 250-261 and trace how the goroutine uses each range-loop value. Check the surrounding application flow and available project tests; done means the analyzer warning is addressed without changing which slave data is collected.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.