github-vet / github-vet/rangeloop-pointer-findings
cloudfoundry-incubator/quarks-operator: pkg/bosh/manifest/cmd_render_job_tmpls.go; 20 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [cloudfoundry-incubator/quarks-operator](https://www.github.com/cloudfoundry-incubator/quarks-operator) at [pkg/bosh/manifest/cmd_render_job_tmpls.go](https://github.com/cloudfoundry-incubator/quarks-operator/blob/0d4c6ab4d2c8ad4a668d45523be0177f0ab58764/pkg/bosh/manifest/cmd_render_job_tmpls.go#L96-L115)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to instance is reassigned at line 101
[Click here to see the code in its original context.](https://github.com/cloudfoundry-incubator/quarks-operator/blob/0d4c6ab4d2c8ad4a668d45523be0177f0ab58764/pkg/bosh/manifest/cmd_render_job_tmpls.go#L96-L115)
Click here to show the 20 line(s) of Go which triggered the analyzer.
```go
for _, instance := range job.Properties.Quarks.Instances {
if len(currentInstanceGroup.AZs) > 0 {
for azIndex, az := range currentInstanceGroup.AZs {
if instance.AZ == az {
if instance.Instance+azIndex*10000 == specIndex {
currentJobInstance = &instance
break
}
}
}
if currentJobInstance != nil {
break
}
} else {
if instance.Index == specIndex {
currentJobInstance = &instance
break
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 0d4c6ab4d2c8ad4a668d45523be0177f0ab58764
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.