github-vet / github-vet/rangeloop-pointer-findings
octarinesec/MAPL: MAPL_engine/conditions_tree.go; 24 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [octarinesec/MAPL](https://www.github.com/octarinesec/MAPL) at [MAPL_engine/conditions_tree.go](https://github.com/octarinesec/MAPL/blob/9c4eb354e4324bf1fd2c34e1b8cc7b4092a141b4/MAPL_engine/conditions_tree.go#L285-L308)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to val is reassigned at line 286
[Click here to see the code in its original context.](https://github.com/octarinesec/MAPL/blob/9c4eb354e4324bf1fd2c34e1b8cc7b4092a141b4/MAPL_engine/conditions_tree.go#L285-L308)
Click here to show the 24 line(s) of Go which triggered the analyzer.
```go
for _, val := range rawArrayData {
message.RequestJsonRawRelative = &val
flag, _ := a.Node.Eval(message)
if flag {
result = true
if a.ReturnValueJsonpath != nil {
extraDataTemp := map[string]interface{}{}
for k, v := range a.ReturnValueJsonpath {
extraDataBytes, _ := jsonslice.Get(val, v)
var tempInterface interface{}
err := json.Unmarshal(extraDataBytes, &tempInterface)
if err == nil {
extraDataTemp[k] = tempInterface
}
//extraDataTemp := string(extraDataBytes)
//extraDataTemp, _ = removeQuotes(extraDataTemp)
}
extraData = append(extraData, extraDataTemp)
}
if !checkAllValuesInTheArray {
return result, extraData
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 9c4eb354e4324bf1fd2c34e1b8cc7b4092a141b4
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.