github-vet / github-vet/rangeloop-pointer-findings

vitpelekhaty/go-tvguide: internal/pkg/playlists/guide.go; 3 LoC

Open
#16,139 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [vitpelekhaty/go-tvguide](https://www.github.com/vitpelekhaty/go-tvguide) at [internal/pkg/playlists/guide.go](https://github.com/vitpelekhaty/go-tvguide/blob/d0546864d183abb8cb82231c6a78c397a9156885/internal/pkg/playlists/guide.go#L461-L463)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to a is reassigned at line 462

[Click here to see the code in its original context.](https://github.com/vitpelekhaty/go-tvguide/blob/d0546864d183abb8cb82231c6a78c397a9156885/internal/pkg/playlists/guide.go#L461-L463)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for idx, a := range p.Credits.Actors {
actors[idx] = &a
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: d0546864d183abb8cb82231c6a78c397a9156885

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in internal/pkg/playlists/guide.go at lines 461-463 and read how actors is populated and consumed. Review the analyzer finding about the range variable, then verify that the resulting actor references remain correct and validate the behavior with the repository's relevant tests, if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.