github-vet / github-vet/rangeloop-pointer-findings

vitpelekhaty/go-tvguide: internal/pkg/playlists/guide.go; 3 LoC

Open
#16,130 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [vitpelekhaty/go-tvguide](https://www.github.com/vitpelekhaty/go-tvguide) at [internal/pkg/playlists/guide.go](https://github.com/vitpelekhaty/go-tvguide/blob/d0546864d183abb8cb82231c6a78c397a9156885/internal/pkg/playlists/guide.go#L533-L535)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to d is reassigned at line 534

[Click here to see the code in its original context.](https://github.com/vitpelekhaty/go-tvguide/blob/d0546864d183abb8cb82231c6a78c397a9156885/internal/pkg/playlists/guide.go#L533-L535)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for idx, d := range p.Credits.Directors {
directors[idx] = &d
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: d0546864d183abb8cb82231c6a78c397a9156885

Contributor guide

No contributing guide indexed for this repository

Research direction

Open internal/pkg/playlists/guide.go at lines 533-535 and inspect the surrounding director-list handling. Check the analyzer's concern about taking a reference to the range variable, then determine whether the reported behavior is a bug, mitigated, or desirable; record the appropriate classification reaction when confirmed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.