github-vet / github-vet/rangeloop-pointer-findings

abmicyau/cs416-blockart: ink-miner.go; 10 LoC

Open
#16,023 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [abmicyau/cs416-blockart](https://www.github.com/abmicyau/cs416-blockart) at [ink-miner.go](https://github.com/abmicyau/cs416-blockart/blob/85a044717594aaf43dcaeefced4a723ac7daec28/ink-miner.go#L1288-L1297)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to opRecord is reassigned at line 1293

[Click here to see the code in its original context.](https://github.com/abmicyau/cs416-blockart/blob/85a044717594aaf43dcaeefced4a723ac7daec28/ink-miner.go#L1288-L1297)

Click here to show the 10 line(s) of Go which triggered the analyzer.

```go
for _, opRecord := range block.Records {
if !m.validateSignature(opRecord) {
blockValid = false
}
if opRecord.Op.Type == REMOVE {
removeOps[opRecord.OpSig] = &opRecord
} else {
addOps[opRecord.OpSig] = &opRecord
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 85a044717594aaf43dcaeefced4a723ac7daec28

Contributor guide

No contributing guide indexed for this repository

Research direction

Read ink-miner.go lines 1288-1297 and the linked repository context, starting with the range-loop references shown in the snippet. Decide whether the analyzer report represents a bug, mitigated behavior, or desirable behavior, then leave the requested reaction to classify the finding.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.