github-vet / github-vet/rangeloop-pointer-findings

rohitramu/kpm: subcommands/common/name_and_version.go; 6 LoC

Open
#16,010 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [rohitramu/kpm](https://www.github.com/rohitramu/kpm) at [subcommands/common/name_and_version.go](https://github.com/rohitramu/kpm/blob/84f17a841d5e6528401084b83a0d559838cf039a/subcommands/common/name_and_version.go#L47-L52)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to currentVersion is reassigned at line 50

[Click here to see the code in its original context.](https://github.com/rohitramu/kpm/blob/84f17a841d5e6528401084b83a0d559838cf039a/subcommands/common/name_and_version.go#L47-L52)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, currentVersion := range availableVersions {
// Keep replacing the current version if we found a higher matching version until we get to the end of the matched list
if highestVersion == nil || currentVersion > *highestVersion {
highestVersion = ¤tVersion
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 84f17a841d5e6528401084b83a0d559838cf039a

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.