github-vet / github-vet/rangeloop-pointer-findings

Juniper/contrail-operator: pkg/apis/contrail/v1alpha1/zz_generated.deepcopy.go; 13 LoC

Open
#16,008 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Juniper/contrail-operator](https://www.github.com/Juniper/contrail-operator) at [pkg/apis/contrail/v1alpha1/zz_generated.deepcopy.go](https://github.com/Juniper/contrail-operator/blob/ad83eeec28cdaf1b1258c0f06a77b3e8820c3401/pkg/apis/contrail/v1alpha1/zz_generated.deepcopy.go#L4524-L4536)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 4529

[Click here to see the code in its original context.](https://github.com/Juniper/contrail-operator/blob/ad83eeec28cdaf1b1258c0f06a77b3e8820c3401/pkg/apis/contrail/v1alpha1/zz_generated.deepcopy.go#L4524-L4536)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal map[string]WebUIServiceStatus
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(WebUIServiceStatusMap, len(*in))
for key, val := range *in {
(*out)[key] = val
}
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ad83eeec28cdaf1b1258c0f06a77b3e8820c3401

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect pkg/apis/contrail/v1alpha1/zz_generated.deepcopy.go around lines 4524-4536 and review the analyzer's range-loop finding in context. Determine whether the reassignment is an actual bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.