github-vet / github-vet/rangeloop-pointer-findings
nathanhack/observer: internal/topic/topic.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [nathanhack/observer](https://www.github.com/nathanhack/observer) at [internal/topic/topic.go](https://github.com/nathanhack/observer/blob/5fe69d95bf75ecb6d8c5cf83d6f31168965c64a5/internal/topic/topic.go#L105-L111)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable ch used in defer or goroutine at line 108
[Click here to see the code in its original context.](https://github.com/nathanhack/observer/blob/5fe69d95bf75ecb6d8c5cf83d6f31168965c64a5/internal/topic/topic.go#L105-L111)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for id, ch := range t.Channels {
if _, has := filterOutIDs[id]; !has {
go func() {
ch <- data
}()
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 5fe69d95bf75ecb6d8c5cf83d6f31168965c64a5
Contributor guide
No contributing guide indexed for this repository
Research direction
Read internal/topic/topic.go around lines 105-111 and inspect the linked commit context. Trace how t.Channels and the launched goroutines are used, then decide whether the reported range-variable behavior is a Bug, Mitigated, or Desirable Behavior and leave the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100