github-vet / github-vet/rangeloop-pointer-findings

albertrdixon/romulus: Godeps/_workspace/src/k8s.io/kubernetes/pkg/api/v1/types.generated.go; 15 LoC

Open
#15,997 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [albertrdixon/romulus](https://www.github.com/albertrdixon/romulus) at [Godeps/_workspace/src/k8s.io/kubernetes/pkg/api/v1/types.generated.go](https://github.com/albertrdixon/romulus/blob/5a0bf879172a8077a17d89589d4b35c81db13516/Godeps/_workspace/src/k8s.io/kubernetes/pkg/api/v1/types.generated.go#L48198-L48212)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to yyv3792 is reassigned at line 48202

[Click here to see the code in its original context.](https://github.com/albertrdixon/romulus/blob/5a0bf879172a8077a17d89589d4b35c81db13516/Godeps/_workspace/src/k8s.io/kubernetes/pkg/api/v1/types.generated.go#L48198-L48212)

Click here to show the 15 line(s) of Go which triggered the analyzer.

```go
for yyk3792, yyv3792 := range v {
z.EncSendContainerState(codecSelfer_containerMapKey1234)
yyk3792.CodecEncodeSelf(e)
z.EncSendContainerState(codecSelfer_containerMapValue1234)
yy3793 := &yyv3792
yym3794 := z.EncBinary()
_ = yym3794
if false {
} else if z.HasExtensions() && z.EncExt(yy3793) {
} else if !yym3794 && z.IsJSONHandle() {
z.EncJSONMarshal(yy3793)
} else {
z.EncFallback(yy3793)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 5a0bf879172a8077a17d89589d4b35c81db13516

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the referenced range in Godeps/_workspace/src/k8s.io/kubernetes/pkg/api/v1/types.generated.go around lines 48198-48212 and review the analyzer message about yyv3792. Determine whether the reported reassignment is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.