github-vet / github-vet/rangeloop-pointer-findings

commshare/testCPP: testgo/main/test_go_wait_all_goroutines_finished.go; 11 LoC

Open
#15,949 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [commshare/testCPP](https://www.github.com/commshare/testCPP) at [testgo/main/test_go_wait_all_goroutines_finished.go](https://github.com/commshare/testCPP/blob/81ec9e84df7f133513335ce55ad9b17c38cb7910/testgo/main/test_go_wait_all_goroutines_finished.go#L30-L40)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable i used in defer or goroutine at line 32

[Click here to see the code in its original context.](https://github.com/commshare/testCPP/blob/81ec9e84df7f133513335ce55ad9b17c38cb7910/testgo/main/test_go_wait_all_goroutines_finished.go#L30-L40)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for i, url := range urls {
go func(url string) {
fmt.Printf("fetch goroutine...%v \n", i)
body, err := fetch(url)
if err != nil {
errc <- err
return
}
resc <- string(body)
}(url)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 81ec9e84df7f133513335ce55ad9b17c38cb7910

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect testgo/main/test_go_wait_all_goroutines_finished.go around lines 30-40 and read the reported range-loop finding. Determine whether the captured loop variable creates an actual bug, is mitigated by the surrounding code, or is desirable behavior, then apply the matching reaction to the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.