github-vet / github-vet/rangeloop-pointer-findings

mathpl/logmetrics: logtail.go; 3 LoC

Open
#15,939 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [mathpl/logmetrics](https://www.github.com/mathpl/logmetrics) at [logtail.go](https://github.com/mathpl/logmetrics/blob/75a6835c9f3fe3f7620a5eee7455997c25e70827/logtail.go#L222-L224)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable t used in defer or goroutine at line 223

[Click here to see the code in its original context.](https://github.com/mathpl/logmetrics/blob/75a6835c9f3fe3f7620a5eee7455997c25e70827/logtail.go#L222-L224)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, t := range allTailers {
go func() { t.Bye <- true }()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 75a6835c9f3fe3f7620a5eee7455997c25e70827

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect logtail.go at lines 222-224 and the surrounding use of allTailers to understand the intended shutdown behavior for each tailer. Check whether the reported range-loop capture can target the wrong tailer, then run any available project checks and verify that every tailer is signaled as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.