github-vet / github-vet/rangeloop-pointer-findings

gradienthealth/dicom: dicomutil/dicomutil.go; 4 LoC

Open
#15,872 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gradienthealth/dicom](https://www.github.com/gradienthealth/dicom) at [dicomutil/dicomutil.go](https://github.com/gradienthealth/dicom/blob/7c0f36edde82d2183f5a811a4b8cdf3712a321b2/dicomutil/dicomutil.go#L88-L91)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to frame at line 90 may start a goroutine

[Click here to see the code in its original context.](https://github.com/gradienthealth/dicom/blob/7c0f36edde82d2183f5a811a4b8cdf3712a321b2/dicomutil/dicomutil.go#L88-L91)

Click here to show the 4 line(s) of Go which triggered the analyzer.

```go
for frameIndex, frame := range data.Frames {
wg.Add(1)
go generateImage(&frame, frameIndex, &wg)
}

```

Click here to show extra information the analyzer produced.

```
The following graphviz dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
digraph G {
"(generateImage, 3)" -> {}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7c0f36edde82d2183f5a811a4b8cdf3712a321b2

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with dicomutil/dicomutil.go at lines 88-91 and inspect generateImage, focusing on how the frame reference is used when the goroutine runs. Check the surrounding range-loop behavior and any relevant tests or reproduction paths. Done means deciding whether the analyzer finding is a Bug, Mitigated, or Desirable Behavior and leaving the requested reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.