github-vet / github-vet/rangeloop-pointer-findings

blackducksoftware/synopsysctl: pkg/synopsysctl/cmd_update.go; 14 LoC

Open
#15,862 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [blackducksoftware/synopsysctl](https://www.github.com/blackducksoftware/synopsysctl) at [pkg/synopsysctl/cmd_update.go](https://github.com/blackducksoftware/synopsysctl/blob/932fd9e043f9089b9ef6fa21eb151c1fccac21de/pkg/synopsysctl/cmd_update.go#L364-L377)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to v was used in a composite literal at line 372

[Click here to see the code in its original context.](https://github.com/blackducksoftware/synopsysctl/blob/932fd9e043f9089b9ef6fa21eb151c1fccac21de/pkg/synopsysctl/cmd_update.go#L364-L377)

Click here to show the 14 line(s) of Go which triggered the analyzer.

```go
for _, v := range secrets {
if secret, err := util.GetSecret(kubeClient, namespace, v.Name); err == nil {
secret.Data = v.Data
secret.StringData = v.StringData
if _, err := util.UpdateSecret(kubeClient, namespace, secret); err != nil {
return fmt.Errorf("failed to update the %s secret due to %+v", v.Name, err)
}
} else {
if _, err := kubeClient.CoreV1().Secrets(namespace).Create(&v); err != nil {
return fmt.Errorf("failed to create the %s secret due to %+v", v.Name, err)
}
}
isSecretUpdated = true
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 932fd9e043f9089b9ef6fa21eb151c1fccac21de

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.